Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency chrome-launcher to v0.13.0 #1847

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 27, 2020

This PR contains the following updates:

Package Type Update Change
chrome-launcher dependencies minor 0.12.0 -> 0.13.0

Release Notes

GoogleChrome/chrome-launcher

v0.13.0

Compare Source

  • 83da1e41 feat: add killAll function (#​186)
  • b8c89f84 flags: disable the default browser check (#​181) (#​182)
  • 6112555c fix: log taskkill error based on logging opts (#​178) (#​179)
  • 7c935efa docs: add missing quote in README.md example (#​180)
  • 2e829c7d Skip --disable-setuid-sandbox flag when ignoreDefaultFlags = true (#​171)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e00312b on renovate/chrome-launcher-0.x into 9735a1f on master.

@rpl
Copy link
Member

rpl commented Mar 2, 2020

This PR is going to fix #1781 and so the failure on travis is expected, we just need to update the expected "default chrome flags" in the related test case:

it('uses the expected chrome flags', () => {
// Flags from chrome-launcher v0.12.0
const expectedFlags = [
'--disable-features=TranslateUI',
'--disable-component-extensions-with-background-pages',
'--disable-background-networking',
'--disable-sync',
'--metrics-recording-only',
'--disable-default-apps',
'--no-first-run',
'--disable-backgrounding-occluded-windows',
'--disable-renderer-backgrounding',
'--disable-background-timer-throttling',
];
assert.deepEqual(DEFAULT_CHROME_FLAGS, expectedFlags);
});

@rpl rpl closed this in #1865 Mar 20, 2020
@renovate renovate bot deleted the renovate/chrome-launcher-0.x branch March 20, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants