Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency watchpack to v2 #2024

Merged
merged 5 commits into from
Feb 22, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 18, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
watchpack 1.7.5 -> 2.1.1 age adoption passing confidence

Release Notes

webpack/watchpack

v2.1.1

Compare Source

Bugfix

  • fix warnings with ENOENT when symlinks are resolved by watchpack

v2.1.0

Compare Source

Bugfix

  • use creation time instead of modified time for folder entries that are only watch for existence
    • fixes a problem where webpack rebuilds unnecessarily

v2.0.1

Compare Source

Bugfix

  • fix incorrectly reported changes when attaching to an already watched directory

v2.0.0

Compare Source

Features

  • Polling no longer uses fs.watchFile but polls the directory directly
  • add ignored option
  • add followSymlinks option
  • allow all Iterables instead of only Array passes as arguments
  • Changed API to take an options object
    • Old API is also accepted without warning (it may be deprecated in the next major)
  • emit remove event when files or directories are not found during initial scan
    • It's assumed that they are removed between reading and watching start
  • add watching of missing items
  • Support /RegExp/ for ignored option
  • limit maximum number of os watchers on OSX to 2000 and on windows to 10000
    • limit can be changed with WATCHPACK_WATCHER_LIMIT environment variable
    • once limit is reached watchers are merged into recursive watchers
  • merge multiple os watchers from watchers with different options into one os watcher
  • add logging of recursive watchers when WATCHPACK_RECURSIVE_WATCHER_LOGGING env var is set

Bugfixes

  • Normalize readdir result to NFC
  • Skip watching the root of the filesystem as file even when requested
  • use options identify instead of stringified options to merge watchers
  • removals and changes in the aggregated event no longer both contain a file
  • aggregateTimeout: 0 now works correctly
  • don't fire change events when files are only read
  • fix handling of renames that only change the casing of files on a case-insensitive filesystem

Performance

  • avoid calling process.nextTick when unneeded on watcher creation
  • cache time entry map in Watcher
  • close watchers faster
  • avoid an unneeded filter call

Dependencies

  • remove neo-async dependency to be smaller

Contributing

  • added prettier
  • node 14 in CI
  • test watcher limit of 1 on CI

Changes

  • increase minimum node.js version to 10
  • initial scan do not fire change events when no start time is provided
  • improve polling schedule to not try to poll faster than the scanning

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@rpl
Copy link
Member

rpl commented Sep 18, 2020

There are test failures triggered by this watchpack updates, we need to look into those before merging this.

@renovate renovate bot force-pushed the renovate/watchpack-2.x branch from d7754ba to 32c73a5 Compare October 1, 2020 12:08
@renovate renovate bot force-pushed the renovate/watchpack-2.x branch 4 times, most recently from a78db96 to 422fc68 Compare November 5, 2020 20:07
@renovate renovate bot force-pushed the renovate/watchpack-2.x branch 3 times, most recently from 206c2a1 to e0487d5 Compare November 13, 2020 12:05
@renovate renovate bot force-pushed the renovate/watchpack-2.x branch 3 times, most recently from 3b83f17 to 83d644a Compare December 8, 2020 10:55
@renovate renovate bot force-pushed the renovate/watchpack-2.x branch 2 times, most recently from 7dd802a to ef5b109 Compare December 17, 2020 19:40
@renovate renovate bot force-pushed the renovate/watchpack-2.x branch 2 times, most recently from 89ecb41 to 63d228b Compare January 8, 2021 20:04
@renovate renovate bot force-pushed the renovate/watchpack-2.x branch from 63d228b to 907713c Compare January 19, 2021 12:04
@rpl rpl force-pushed the renovate/watchpack-2.x branch 2 times, most recently from 4682908 to bae0fcd Compare January 19, 2021 14:17
@rpl rpl requested review from rpl and Rob--W and removed request for rpl January 19, 2021 14:24
@rpl rpl self-assigned this Jan 19, 2021
@rpl rpl removed the request for review from Rob--W January 19, 2021 15:24
@rpl
Copy link
Member

rpl commented Jan 19, 2021

Apparently one test is still failing when running on windows:

I'll take a look at that and then add back Rob as a reviewer on this PR.

@renovate renovate bot force-pushed the renovate/watchpack-2.x branch from bae0fcd to 86973bc Compare January 21, 2021 12:44
@rpl
Copy link
Member

rpl commented Feb 22, 2021

Let's hope that nobody uses \ to escape sequences.

yeah, I was thinking about that too, if I'm not mistaken that replace call shouldn't affect a path where the user did escape a whitespace character (which I think is not that uncommon on Windows), e.g.:

❯ node
> "C:\\Users\\My\ User\ Name\\Some\\Path"
'C:\\Users\\My User Name\\Some\\Path'
> "C:\\Users\\My\ User\ Name\\Some\\Path".replace(/\\/g, '/')
'C:/Users/My User Name/Some/Path'

@rpl rpl merged commit 13861a0 into master Feb 22, 2021
@rpl rpl deleted the renovate/watchpack-2.x branch February 22, 2021 13:03
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants