Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies and nsprc to fix npm audit failures in CI jobs #2323

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

rpl
Copy link
Member

@rpl rpl commented Oct 11, 2021

CI jobs are currently failing in all recent pull requests because the "npm audit deps" CI job step is currently reporting some issues.

This PR contains a commit with changes to package.json and package-lock.json files, generated by running npm audit fix locally,
unfortunately that isn't enough because update-notifier (and @commitlint/cli) has not released a new version with the dependencies update that would prevent npm audit from still failing because of the ansi-regex version part of the web-ext dependencies and so I had to add it as an exception in the .nsprc file (the exception @commitlint/cli is also unfortunate but it is also a dev-only dependency).

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #2323 (8def9e8) into master (1a0c926) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          32       32           
  Lines        1699     1699           
=======================================
  Hits         1697     1697           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0c926...8def9e8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant