Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing type for channel parameter #2570

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

merrx
Copy link
Contributor

@merrx merrx commented Dec 5, 2022

Fixes #2546

This PR adds the missing type statement.

@merrx merrx force-pushed the fix-package.json-channel branch from 53c82ce to fd9cc9c Compare December 5, 2022 16:04
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 99.52% // Head: 99.52% // No change to project coverage 👍

Coverage data is based on head (def35d4) compared to base (e975ab9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2570   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          32       32           
  Lines        1697     1697           
=======================================
  Hits         1689     1689           
  Misses          8        8           
Impacted Files Coverage Δ
src/program.js 98.57% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@merrx merrx force-pushed the fix-package.json-channel branch from fd9cc9c to def35d4 Compare December 5, 2022 16:12
@rpl rpl merged commit 6356fa9 into mozilla:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in web-ext using a package.json configfile
3 participants