feat: use .web-ext-config.js for automatic discovery
#2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2843 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 32 32
Lines 1761 1761
=======================================
Hits 1752 1752
Misses 9 9
☔ View full report in Codecov by Sentry. |
rpl
requested changes
Aug 17, 2023
uiolee
changed the title
.web-ext-config.js for automatic discovery.web-ext-config.js for automatic discovery
rpl
reviewed
Sep 28, 2023
There was a problem hiding this comment.
@uiolee Apologies for the long time we needed to get back to this PR, I just took a look and it looks pretty r+ with just the warning removed and one or two small tweaks on the tests side (the one I actually care more about on the test side is the review comment related to leave the custom config file passes using --config to not be dotted as it was originally in that test case, but just add to that test the needed changes to confirm we also looked for the dotted file name in the project dir).
renovate bot
referenced
this pull request
in JoshuaKGoldberg/refined-saved-replies
May 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [web-ext](https://togithub.com/mozilla/web-ext) | [`^7.8.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/web-ext/7.12.0/8.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mozilla/web-ext (web-ext)</summary> ### [`v8.0.0`](https://togithub.com/mozilla/web-ext/releases/tag/8.0.0) [Compare Source](https://togithub.com/mozilla/web-ext/compare/7.12.0...8.0.0) #### What's changed 300+ commits have been written to get this new version 8 out of the door (see link to the full changelog at the bottom). Please take a look at the [official documentation](https://extensionworkshop.com/documentation/develop/web-ext-command-reference/) to know what has changed but expect some breaking changes. Specifically, `web-ext sign` has been heavily refactored. Among other things, you can create new add-ons (not just versions) from the command line now 🎉 Unfortunately, this command is not backward compatible with v7. While we're keeping the v7 branch around to ease the transition, we will mainly fix bugs and introduce new features in v8. #### New contributors - [@​zmckenney](https://togithub.com/zmckenney) made their first contribution in [https://github.com/mozilla/web-ext/pull/2734](https://togithub.com/mozilla/web-ext/pull/2734) - [@​uiolee](https://togithub.com/uiolee) made their first contribution in [https://github.com/mozilla/web-ext/pull/2843](https://togithub.com/mozilla/web-ext/pull/2843) - [@​afonsojramos](https://togithub.com/afonsojramos) made their first contribution in [https://github.com/mozilla/web-ext/pull/2760](https://togithub.com/mozilla/web-ext/pull/2760) - [@​lm1](https://togithub.com/lm1) made their first contribution in [https://github.com/mozilla/web-ext/pull/2857](https://togithub.com/mozilla/web-ext/pull/2857) - [@​dotproto](https://togithub.com/dotproto) made their first contribution in [https://github.com/mozilla/web-ext/pull/3111](https://togithub.com/mozilla/web-ext/pull/3111) **Full changelog**: mozilla/web-ext@7.12.0...8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/JoshuaKGoldberg/refined-saved-replies). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2812.
use
./.web-ext-config.jsfor automatic discovery,instead of./web-ext-config.js