fix: Cannot find Firefox package on device with work profile #2857

lm1 · 2023-09-01T22:36:35Z

On some devices with work profile enabled, adb shell pm list packages will fail with permission error.
Avoid reaching work profile and scan packages for the primary user instead.

codecov · 2023-09-02T07:53:02Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ac17631) 99.31% compared to head (f448aca) 99.26%.

❗ Current head f448aca differs from pull request most recent head 4f26012. Consider uploading reports for the commit 4f26012 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2857      +/-   ##
==========================================
- Coverage   99.31%   99.26%   -0.06%     
==========================================
  Files          32       32              
  Lines        1753     1760       +7     
==========================================
+ Hits         1741     1747       +6     
- Misses         12       13       +1

Files	Coverage Δ
src/util/adb.js	`99.30% <87.50%> (-0.70%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/util/adb.js

lm1 · 2023-11-12T22:40:48Z

Codecov complains about the new exception line testing the result of (am get-current-user), but that's extremally unlikely condition as the command result is tested earlier, so perhaps does not require an additional test.

src/util/adb.js

tests/unit/test-util/test.adb.js

Rob--W

I started the review before the patch update; I'll drop the comments that I had below and will revisit this PR later for another review round.

tests/unit/test-util/test.adb.js

lm1 · 2023-11-23T17:45:11Z

I started the review before the patch update; I'll drop the comments that I had below and will revisit this PR later for another review round.

Was in a bit of a haste due to a trip last week, but hope the PR is good to merge as of the last code push. Responded to the remaining comments.

Rob--W

Thanks for the patch and tests!

…3146) Co-authored-by: lm1 <mielicki@gmail.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [web-ext](https://togithub.com/mozilla/web-ext) | [`^7.8.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/web-ext/7.12.0/8.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/web-ext/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/web-ext/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/web-ext/7.12.0/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/web-ext/7.12.0/8.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mozilla/web-ext (web-ext)</summary> ### [`v8.0.0`](https://togithub.com/mozilla/web-ext/releases/tag/8.0.0) [Compare Source](https://togithub.com/mozilla/web-ext/compare/7.12.0...8.0.0) #### What's changed 300+ commits have been written to get this new version 8 out of the door (see link to the full changelog at the bottom). Please take a look at the [official documentation](https://extensionworkshop.com/documentation/develop/web-ext-command-reference/) to know what has changed but expect some breaking changes. Specifically, `web-ext sign` has been heavily refactored. Among other things, you can create new add-ons (not just versions) from the command line now 🎉 Unfortunately, this command is not backward compatible with v7. While we're keeping the v7 branch around to ease the transition, we will mainly fix bugs and introduce new features in v8. #### New contributors - [@zmckenney](https://togithub.com/zmckenney) made their first contribution in [https://github.com/mozilla/web-ext/pull/2734](https://togithub.com/mozilla/web-ext/pull/2734) - [@uiolee](https://togithub.com/uiolee) made their first contribution in [https://github.com/mozilla/web-ext/pull/2843](https://togithub.com/mozilla/web-ext/pull/2843) - [@afonsojramos](https://togithub.com/afonsojramos) made their first contribution in [https://github.com/mozilla/web-ext/pull/2760](https://togithub.com/mozilla/web-ext/pull/2760) - [@lm1](https://togithub.com/lm1) made their first contribution in [https://github.com/mozilla/web-ext/pull/2857](https://togithub.com/mozilla/web-ext/pull/2857) - [@dotproto](https://togithub.com/dotproto) made their first contribution in [https://github.com/mozilla/web-ext/pull/3111](https://togithub.com/mozilla/web-ext/pull/3111) **Full changelog**: mozilla/web-ext@7.12.0...8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/JoshuaKGoldberg/refined-saved-replies).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

lm1 changed the title ~~Scan packages of the primary user instead of the work profile~~ fix: Cannot find Firefox package on device with work profile Sep 1, 2023

lm1 force-pushed the patch-4 branch 2 times, most recently from 58558a8 to 5d1ed46 Compare September 2, 2023 07:46

Rob--W reviewed Sep 28, 2023

View reviewed changes

src/util/adb.js Outdated Show resolved Hide resolved

Rob--W mentioned this pull request Oct 26, 2023

Secure folder causes error during web-ext run #2903

Closed

lm1 force-pushed the patch-4 branch from 5d1ed46 to f448aca Compare November 12, 2023 22:27

Rob--W reviewed Nov 13, 2023

View reviewed changes

src/util/adb.js Outdated Show resolved Hide resolved

src/util/adb.js Outdated Show resolved Hide resolved

tests/unit/test-util/test.adb.js Show resolved Hide resolved

tests/unit/test-util/test.adb.js Show resolved Hide resolved

tests/unit/test-util/test.adb.js Show resolved Hide resolved

lm1 force-pushed the patch-4 branch from f448aca to f1493aa Compare November 13, 2023 19:57

fix: Cannot find Firefox package on device with work profile

4f26012

lm1 force-pushed the patch-4 branch from f1493aa to 4f26012 Compare November 13, 2023 20:08

Rob--W reviewed Nov 14, 2023

View reviewed changes

tests/unit/test-util/test.adb.js Show resolved Hide resolved

tests/unit/test-util/test.adb.js Show resolved Hide resolved

Rob--W approved these changes Jan 16, 2024

View reviewed changes

Rob--W merged commit 2bef8ce into mozilla:master Jan 16, 2024

Rob--W mentioned this pull request May 23, 2024

web-ext has no way to specify a user to use on Android, causing it to fail. #3116

Closed

willdurand pushed a commit that referenced this pull request May 27, 2024

fix: Cannot find Firefox package on device with work profile (#2857)

886093c

willdurand pushed a commit that referenced this pull request May 27, 2024

fix: Cannot find Firefox package on device with work profile (#2857)

241acd8

willdurand added a commit that referenced this pull request May 27, 2024

fix: Cannot find Firefox package on device with work profile (#2857) (#…

e1566a2

…3146) Co-authored-by: lm1 <mielicki@gmail.com>

SpinningRecords mentioned this pull request Jul 20, 2024

[Snyk] Upgrade web-ext from 7.6.2 to 7.12.0 SpinningRecords/FastForward#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Cannot find Firefox package on device with work profile #2857

fix: Cannot find Firefox package on device with work profile #2857

lm1 commented Sep 1, 2023

codecov bot commented Sep 2, 2023 •

edited

Loading

lm1 commented Nov 12, 2023 •

edited

Loading

Rob--W left a comment

lm1 commented Nov 23, 2023

Rob--W left a comment

fix: Cannot find Firefox package on device with work profile #2857

fix: Cannot find Firefox package on device with work profile #2857

Conversation

lm1 commented Sep 1, 2023

codecov bot commented Sep 2, 2023 • edited Loading

Codecov Report

lm1 commented Nov 12, 2023 • edited Loading

Rob--W left a comment

Choose a reason for hiding this comment

lm1 commented Nov 23, 2023

Rob--W left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 2, 2023 •

edited

Loading

lm1 commented Nov 12, 2023 •

edited

Loading