Handle labels in META.yml files #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only correctly handled metadata entries which had a "url" key, which generally speaking labels do not. In practice that meant we failed to notify for test changes in directories with labels. This change adds a specific type to represent labels and ensure that they're correctly roundtripped through the update process. This matches the data representation used in other tooling, but we will still need to update the code if a new kind of metadata is added.
lutien
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only correctly handled metadata entries which had a "url" key, which generally speaking labels do not. In practice that meant we failed to notify for test changes in directories with labels.
This change adds a specific type to represent labels and ensure that they're correctly roundtripped through the update process.
This matches the data representation used in other tooling, but we will still need to update the code if a new kind of metadata is added.