Add Cargo features and code to allow OpenSSL to be used for Crypto #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramaravishankar
changed the title
|
@moznion can I please get a feedback on this? |
|
@moznion can I please get feedback on this? |
|
@ramaravishankar Thank you for your contribution. Please give me a time to take a look at this. |
|
@moznion sorry for bugging again, we have a dependency on this change, would it be possible for you to review this week? |
moznion
approved these changes
Jan 15, 2024
|
@ramaravishankar I really appreciate your contribution! It seems some of Windows tests failed but the core of the change seems good. I'll merge this pull request and publish the new version which includes this change. Once it has been finished, I'll let you know that. |
|
@ramaravishankar I published v0.4.0 which includes this change. Thank you for your contribution! |
|
Thanks @moznion, cheers 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - thanks for sharing this library!
This change is to add support for using OpenSSL for cryptography instead of the MD5 crate - for cases where only a trusted OpenSSL implementation is supported for anything cryptography related. There's no functional change to the output of the library.
I've added this as a cargo feature so that the MD5 crate is still used by default so as not to impact existing users who don't want the OpenSSL dependency. Using one feature doesn't compile in the dependencies of the other.
I've also added extra workflow steps to test the two feature options explicitly and confirmed these pass.
Let me know if you have any comments.
If you do accept, would you be able to tag a new release as well please?
Thanks again!