native 16bit int and large floats fix #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a processor where an int is 16 bit, the max float value will be capped to 32767 due to type conversions. The PRINTF_MAX_FLOAT define is meant to prevent the limitation being exposed but it was written with 32 bit ints in mind. Explicitly setting the conversion type to int32_t fixes this. Added a note in readme against the define as a gotcha
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 359 359
=========================================
Hits 359 359
Continue to review full report at Codecov.
|
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…th other side effects.
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…uld only be preceded by other preprocessor directives or comments.
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…ll only be used with either a preceding `&`, or with a parenthesized parameter list, which may be empty.
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…ot be used. ... so, when printf is used in C++, we use the C++-version of the C library headers.
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…unction-like macro each instance of a parameter shall be enclosed in parentheses unless it is used as the operand of `#` or `##`.
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
…ed int` all over.
KarlK90
pushed a commit
to qmk/printf
that referenced
this pull request
Jul 7, 2022
* More use of typedef's over raw primitive C types. Specifically, using `printf_size_t` in many relevant places * Regards mpaland#77 * Removed redundant parentheses * Comment tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a processor where an int is 16 bit, the max float value will be capped to 32767 due to type conversions. The PRINTF_MAX_FLOAT define is meant to prevent this limitation being exposed but it was written with 32 bit ints in mind (PRINTF_MAX_FLOAT default of 1e9 is less than int32 max of 2,147,483,647). Explicitly setting the conversion type to int32_t fixes this. Added a note in readme against the define as a gotcha.