Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle Nil URL #8

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: Handle Nil URL #8

merged 1 commit into from
Nov 29, 2022

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • Correctly handle nil clickedURLString

Testing Plan

  • {explain how this has been tested, and what additional testing should be done}

Reference Issue

@BrandonStalnaker BrandonStalnaker self-assigned this Nov 29, 2022
einsteinx2
einsteinx2 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit bc21d37 into development Nov 29, 2022
@BrandonStalnaker BrandonStalnaker deleted the fix/handle-nil-url branch November 29, 2022 22:15
@einsteinx2 einsteinx2 mentioned this pull request Feb 23, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@peterjenkins peterjenkins peterjenkins approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @einsteinx2 @peterjenkins