Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CryptographyAESKey::encrypt to generate 96 bit IVs for GCM block cipher mode to adhere to JWA RFC #355

Merged
merged 1 commit into from
May 30, 2024

Conversation

twwildey
Copy link
Collaborator

Updating CryptographyAESKey::encrypt to generate 96 bit IVs for GCM block cipher mode to adhere to the RFC for JWA in jose/backends/cryptography_backend.py

See https://www.rfc-editor.org/rfc/rfc7518.html#section-5.3 for the official RFC requirements for JWA

See panva/jose#678 for related discussion on this issue

Testing done

Ran the following commands, which successfully built the package and passed all unit tests that were not already failing:

# Setup python-jose project
git clone git@github.com:twwildey/python-jose.git

# Install dependencies for python-jose
cd python-jose
python -m venv .venv
source .venv/bin/activate
python3 -m pip install --upgrade build
python3 -m pip install -r requirements.txt
python3 -m pip install -r requirements-dev.txt

# Build project
python -m build

# Run tests for project
python -m pytest

@twwildey twwildey force-pushed the master branch 2 times, most recently from d67f17c to 72de4a2 Compare May 30, 2024 00:54
… block cipher mode to adhere to the RFC for JWA in `jose/backends/cryptography_backend.py`

See https://www.rfc-editor.org/rfc/rfc7518.html#section-5.3 for the official RFC requirements for JWA

See panva/jose#678 for related discussion on this issue
@twwildey
Copy link
Collaborator Author

I am merging this PR, since the unit tests that are failing now are also failing without these changes locally.

@twwildey twwildey merged commit c533ed6 into mpdavis:master May 30, 2024
2 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant