Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.x error #1893

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix PHP 8.x error #1893

wants to merge 1 commit into from

Conversation

manusfreedom
Copy link

trborder-top and trborder-bottom are not always set.

@manusfreedom
Fix PHP 8.x error
42d6fbb 
trborder-top and trborder-bottom are not always set.
@finwe
Copy link
Member

finwe commented Jun 16, 2023

Thanks for the PR. Add a unit test failing before and passing after your change so that this can be reviewed properly. See tests/Issues directory in the repo. Also check and fix build failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/fix changes-update-requested missing sample / test notices-warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manusfreedom @finwe