Add busted's match global to builtin_standards
#200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The busted project has the concept of matchers than are documented over at https://olivinelabs.com/busted/#matchers and can be used in assertions with the `match` keyword. For example: ```lua assert.spy(s).was_called_with(match.is_string()) ```
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 52 52
Lines 5512 5512
=======================================
Hits 5368 5368
Misses 144 144
Continue to review full report at Codecov.
|
|
@treffynnon If you are still around would you mind opening this branch as a PR against this repository (the new canonical home, see #198). I would be happy to checkout and merge this contribution over there. |
cyphar
added a commit
to cyphar/koreader
that referenced
this pull request
Oct 24, 2021
This is something luacheck should include but the upstream PR to add it[1] hasn't been merged yet, nor has the patch been included in the fork. [1]: mpeterv/luacheck#200 Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The busted project has the concept of matchers than are documented over at
https://olivinelabs.com/busted/#matchers and can be used in assertions with
the
matchkeyword.For example: