Update topology examples 8.8 and 8.10

[schulzm]

Problem

Example: page 412, code for MPI_NEIGHBOR_ALLGATHER

The code is supposed to be binding, but is pseudo code. How should this be handled? Should the code be complete and runnable? How to distinguish this from examples?

Proposal

tbd

Changes to the Text

tbd

Impact on Implementations

tbd

Impact on Users

tbd

References

Insert any internal (other issues) or external (websites, papers, etc.) references here.

[wgropp]

This is also inconsistent with the pseudo code for other collective operations. We do need to decide on a consistent style for these - and I think the pseudo code used elsewhere, instead of almost-C, is the appropriate approach.

[RolfRabenseifner]

This is already treated in issue #393.
The mentioned page 412 is now MPI_4.0 page 419.
This type of documenting the definition of the neighbor procedures for graph topologies is needed to show the used buffer locations. Therefore it is not an example (as also mentioned in issue #393.)
I expect that Fortran programmer are able to translate the byte adressing that is here used for C.
I expect that C programmers are also able to translate it to their definition of sendbuf and recvbuf.
Therefore, I would not spend more time on this and I would recommend to close this issue.

[wgropp]

I disagree - this has not been dealt with. The indicated examples are in no known computer language. The options are:

1. Pick one of C or (some dialect of) Fortran
2. Define a language-neutral form, add a definition for lstlisting to mpi-user-macs, and use that consistently.

I'm leaning towards 2, but would be ok with 1 (especially if the choice is C, since there is only one dialect used in the MPI standard).

[RolfRabenseifner]

Okay, I'll provide a PR.

[RolfRabenseifner]

@wgropp Dear Bill, my apologies, but I do not see what's wrong with MPI-4.0 page 419, lines 6-21? For me, it seems to be correct C code. The same seems for me to be true with all other MPI_Neigbor_ALL... procedures.
And I also do not see a bug in the C code of Example 8.10 on page 424.
Or do you mean some other code? Best regards, Rolf