Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.12 #151

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

GHC 9.12 #151

wants to merge 5 commits into from

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Nov 28, 2024

Update for GHC 9.12.1

@alanz alanz requested a review from zliu41 November 28, 2024 21:10
@alanz
Copy link
Collaborator Author

alanz commented Nov 28, 2024

This is a work in progress.
It needs cleaning up, I spread CPP everywhere, and broke the non-9.12.1 versions

And if I run

cabal test --test-option="-p /Fixity.hs/"

It fails with

    Expected type not found at the location specified in the refact file.
      Expected type: HsExpr (GhcPass 'Parsed)
      Location: tests/examples/Fixity.hs:1:21-27: inappropriate type

And that span is not in the new AST. So I am not sure if the refact test file needs updating

@alanz
Copy link
Collaborator Author

alanz commented Dec 5, 2024

I am down to 3 failures, all of which are perhaps "external"

    Use -p '/tests\/examples\/Structure7.hs/' to rerun this test only.

Caused by a spacing change in ghc-exactprint where there is now a new LHS counter initialisation to 0 not 1, to match nested logic, but gives off by one at the top level.

The next two are related to the refact hint input not matching the span, because the AST shows up differently. I am not sure how to deal with them

    Use -p '/tests\/examples\/Lambda37.hs/' to rerun this test only.
    Use -p '/tests\/examples\/EtaReduceLocalTypeSig.hs/' to rerun this test only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant