Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter 3.0.0 is detecting issue with the library #16

Closed
RoyalCoder88 opened this issue May 14, 2022 · 2 comments
Closed

Flutter 3.0.0 is detecting issue with the library #16

RoyalCoder88 opened this issue May 14, 2022 · 2 comments

Comments

@RoyalCoder88
Copy link

../../../Documents/flutter/.pub-cache/hosted/pub.dartlang.org/fading_edge_scrollview-2.0.1/lib/src/fading_edge_scrollview.dart:220:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

  • 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Documents/flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.removeObserver(this);
@dJani97
Copy link

dJani97 commented May 17, 2022

Having the same issue.

In Flutter 3, WidgetsBinding.instance is no longer nullable, so the ?. operator is no longer necessary. Please remove these operators.

Reproducible by using Flutter 3 and the latest version of this library in the same project.

@mponkin
Copy link
Owner

mponkin commented May 30, 2022

Fixed in version 3.0.0
Sorry for missing this issue. Been busy with other stuff and haven't seen any notifications.
Thanks to @ruslic19 for providing the PR

@mponkin mponkin closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants