fix(details tab buttons): Ensuring all tabs works as expected

Fixing incorrect looping logic that caused certain tabs not to have events bound to them. #3
mportuga · Nov 29, 2016 · b6b5237 · b6b5237
1 parent a973d63
commit b6b5237
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/helpers/scripts.html b/lib/helpers/scripts.html
@@ -60,7 +60,7 @@
 	}
 
 	// tabs
-	for(var k = 0; k < lintResults.length; k++) {
+	for(var k = 0; k < tabs.length; k++) {
 		tabs[k].addEventListener('click', activateTab);
 	}
 

diff --git a/lib/templates/details/details.html b/lib/templates/details/details.html
@@ -5,6 +5,7 @@
 				<button data-parent=".f-<%= parentIndex %>"
 								data-content="sourceCode-<%= parentIndex %>"
 								aria-controls="sourceCode-<%= parentIndex %>"
+								type="button"
 								role="tab">
 					SourceCode
 				</button>
@@ -13,6 +14,7 @@
 				<button data-parent=".f-<%= parentIndex %>"
 								data-content="detailSummary-<%= parentIndex %>"
 								aria-controls="detailSummary-<%= parentIndex %>"
+								type="button"
 								role="tab">
 					Summary
 				</button>