fix(46466): add missing async keyword before type parameters (microso…

…ft#46467)
mprobst · Jan 10, 2022 · 19be4c6 · 19be4c6
1 parent 0c0fb69
commit 19be4c6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/services/codefixes/fixAwaitInSyncFunction.ts b/src/services/codefixes/fixAwaitInSyncFunction.ts
@@ -53,7 +53,8 @@ namespace ts.codefix {
                 insertBefore = findChildOfKind(containingFunction, SyntaxKind.FunctionKeyword, sourceFile);
                 break;
             case SyntaxKind.ArrowFunction:
-                insertBefore = findChildOfKind(containingFunction, SyntaxKind.OpenParenToken, sourceFile) || first(containingFunction.parameters);
+                const kind = containingFunction.typeParameters ? SyntaxKind.LessThanToken : SyntaxKind.OpenParenToken;
+                insertBefore = findChildOfKind(containingFunction, kind, sourceFile) || first(containingFunction.parameters);
                 break;
             default:
                 return;

diff --git a/tests/cases/fourslash/codeFixAddMissingAsync3.ts b/tests/cases/fourslash/codeFixAddMissingAsync3.ts
@@ -0,0 +1,16 @@
+/// <reference path="fourslash.ts" />
+
+////const foo = <T>(x: T): string => {
+////    await new Promise(resolve => resolve(true));
+////    return "";
+////}
+
+verify.codeFix({
+    description: ts.Diagnostics.Add_async_modifier_to_containing_function.message,
+    index: 0,
+    newFileContent:
+`const foo = async <T>(x: T): Promise<string> => {
+    await new Promise(resolve => resolve(true));
+    return "";
+}`
+});