Skip to content

Commit

Permalink
client API: remove deprecated qthelper.hpp header
Browse files Browse the repository at this point in the history
No replacement. Qt or C++ code has no business in this repository, and
new code (even if it uses Qt) should not use it. Get rid of it.

We consider the libmpv API itself as stable. Symbols can be deprecated,
but not be removed. However, qthelper.hpp was never considered part of
the libmpv API. There no ABI implications either, since it's a header-
only implementation that uses C API symbols only. It's just a header
provided for convenience for Qt/C++ programs (i.e. extremely limited
usefulness).
  • Loading branch information
wm4 committed Mar 6, 2020
1 parent 2337fa4 commit 575197f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 387 deletions.
10 changes: 10 additions & 0 deletions DOCS/client-api-changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ API changes

::

--- mpv 0.33.0 ---
1.107 - Remove the deprecated qthelper.hpp. This was obviously not part of the
libmpv API, only an "additionally" provided helper, thus this is not
considered an API change. If you are maintaining a project that relies
on this header, you can simply download this file and adjust the
include statement to use it instead:

https://raw.githubusercontent.com/mpv-player/mpv/v0.32.0/libmpv/qthelper.hpp

It is a good idea to write better wrappers for your use, though.
--- mpv 0.31.0 ---
1.107 - Deprecate MPV_EVENT_TICK

Expand Down
Loading

0 comments on commit 575197f

Please sign in to comment.