Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird colors when playing 10-bit videos with vo=opengl #1383

Closed
shdown opened this issue Dec 24, 2014 · 4 comments
Closed

Weird colors when playing 10-bit videos with vo=opengl #1383

shdown opened this issue Dec 24, 2014 · 4 comments

Comments

@shdown
Copy link
Contributor

shdown commented Dec 24, 2014

Whereas 8-bit ones are displayed fine, and vo=opengl-old works fine with both.

It is worth mentioning that my system lacks GL_ARB_texture_rg.

Screenshots:
vo=opengl
shot0001

vo=opengl-old
shot0002
@ghost
Copy link

ghost commented Dec 24, 2014

What does it say on the terminal? Look for something like VO: [opengl-old] 1280x720 yuv420p10.

@shdown
Copy link
Contributor Author

shdown commented Dec 24, 2014 

Using conversion filter.
VO: [opengl-old] 1280x720 yuv420p

VO: [opengl] 1280x720 yuv420p10

@ghost
Copy link

ghost commented Dec 24, 2014

So your opengl drivers don't provide proper 16 bit textures, which results in slicing off some bits. opengl-old checks for this and reverts to software conversion, while opengl doesn't yet.

What GPU is this? Can you paste the output of glxinfo?

@shdown
Copy link
Contributor Author

shdown commented Dec 24, 2014

What GPU is this?

Intel GMA 3150

Can you paste the output of glxinfo?

http://sprunge.us/ZZTO

@ghost ghost closed this as completed in 5a30703 Dec 24, 2014
ghost pushed a commit that referenced this issue Jan 24, 2015
vo_opengl: don't use 10 bit video on Intel GPUs
31c4e58 
vo_opengl was originally written against OpenGL 3 core, and it seems
GPUs/drivers supporting this are mostly sane. Later, it was made to work
with OpenGL 2.1 too. Lately we removed the requirement for RG textures,
and look, someone reported a problem with "lesser" Intel GPUs.

This commit does the same in vo_opengl what was added to vo_opengl_old a
long time ago.

Fixes #1383.

Conflicts:
	video/out/gl_common.c
	video/out/gl_video.c
ghost pushed a commit that referenced this issue Jan 24, 2015
vo_opengl: don't use 10 bit video on Intel GPUs
3b9acfe 
vo_opengl was originally written against OpenGL 3 core, and it seems
GPUs/drivers supporting this are mostly sane. Later, it was made to work
with OpenGL 2.1 too. Lately we removed the requirement for RG textures,
and look, someone reported a problem with "lesser" Intel GPUs.

This commit does the same in vo_opengl what was added to vo_opengl_old a
long time ago.

Fixes #1383.

Conflicts:
	video/out/gl_common.c
	video/out/gl_video.c
ghost pushed a commit that referenced this issue Jan 25, 2015
vo_opengl: don't use 10 bit video on Intel GPUs
3d71063 
vo_opengl was originally written against OpenGL 3 core, and it seems
GPUs/drivers supporting this are mostly sane. Later, it was made to work
with OpenGL 2.1 too. Lately we removed the requirement for RG textures,
and look, someone reported a problem with "lesser" Intel GPUs.

This commit does the same in vo_opengl what was added to vo_opengl_old a
long time ago.

Fixes #1383.

Conflicts:
	video/out/gl_common.c
	video/out/gl_video.c
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shdown