-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try "resume-playback", if not seekable #1701
Comments
It doesn't seem 39eb9b7 really fixes this. As far as I can tell mpv is still saving playback state at least on the following streams URLs: http://www.radioswissjazz.ch/live/aacp.m3u
I'm not 100% sure that's not just two borked streams but even then IMHO this would be kind of glitchy behavior since when mpv tries to restore the playback position on the first URL above it will just hang indefinitely. |
demux_lavf.c forces seek to being determined as supported if STREAM_CTRL_HAS_AVSEEK is returned as success. But it always succeeds with current FFmpeg versions. (Seems like Libav commit cae448cf broke this in early 2016.) Now we can't determine via private API whether the underlying protocol supports read_seek anymore. The affected protocols (mostly rtmp) also set seekable=0, meaning they signal they're not seekable, even though read_seek would work. (My guess is that this can't be fixed because even though seekable is in theory a combination of elaborate flags [of which only 1 is defined, AVIO_SEEKABLE_NORMAL], a seekable!=0 always means it's byte-seekable in some way.) So the FFmpeg API is being garbage _again_, and all what we can do is determining this via protocol name and a whitelist. Should fix the behavior reported in #1701.
Should now work better. |
Hi, I know this issue is a bit old but I think it's better than opening a new one. Could you disable resume-playback on special block devices as well? I open |
It should already be considered unseekable (since I expect you can't seek in that device file), but I have no way to test. |
@wm4 Unfortunately not, as you can see here:
Break with
My webcam indicator light turns on, but the video window never appears unless I pass Configuration file: https://my.mixtape.moe/nnivfe.conf I am happy to run patches or testing versions if it will help. |
I have the same problem. Running
Running Mac OS 10.12. |
Looks like FFmpeg’s HLS demuxer just waits around forever until the segment with the requested timestamp arrives. |
Thanks for reopening this, but does that mean that only web streams will be looked at again? As of mpv 0.26.0 block devices still have the same problem. |
FFmpeg's HLS code has had a lot of work done on it recently. Is this still a problem in 0.28.0? |
@thebombzen Just built |
I would open a separate issue reporting this problem. That one has nothing to do with streams, just detecting the seekability of a tv device. |
Hello
The
--save-position-on-quit
is really useful, but when you also often listen to live streams it kind of annoying that you need to specific--no-resume-playback
every time.. When MPV just could check if it is seekable, and if not just play it..Regards Kristian
The text was updated successfully, but these errors were encountered: