Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmpv: resize glitches when embedding video window into layer backed NSView #2873

Closed
ghost opened this issue Feb 26, 2016 · 6 comments
Closed

Comments

@ghost
Copy link

ghost commented Feb 26, 2016

I've record a demo
I using ffmpeg and mpv from HEAD

@ghost
Copy link

ghost commented Feb 26, 2016

Yeah, native embedding mode can be glitchy. I'm not sure what exactly might be causing it, or if it's fixable in theory. The recommendation is using opengl-cb embedding instead.

@ghost
Copy link
Author

ghost commented Feb 26, 2016

Thanks! I'll try this tomorrow, but it is stable enough?

@ghost
Copy link

ghost commented Feb 26, 2016

It's certainly more stable than the window embedding method, but also requires more work in certain areas. I recommend reading the documentation and examples.

@ghost
Copy link
Author

ghost commented Feb 26, 2016

Ok, thanks for suggesting!

27 февр. 2016 г., 1:44 +0300, V. Langnotifications@github.com, писал:

It's certainly more stable than the window embedding method, but also requires more work in certain areas. I recommend reading the documentation and examples.


Reply to this email directly orview it on GitHub(#2873 (comment)).

@Akemi
Copy link
Member

Akemi commented Apr 30, 2017

since the video was taken down i am not sure which glitches were reported here. PR #4391 switches to a layer backed view and also fixes most of the glitches i encountered. so it should also fix this issue.

if you still can test it feel free to.

@Akemi
Copy link
Member

Akemi commented Feb 13, 2018

I experimented a lot with layer backed views and i never got it to work properly with an NSOpenGLContext. the Apple preferred way is to use a CAOpenGLLayer, which the new cocoa-cb backend for opengl-cb uses. sadly the CAOpenGLLayer is mutually exclusive to our gpu cocoa backend, so it's impossible to use there. additionally i deprecated the cocoa backend.

@Akemi Akemi closed this as completed Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant