Crazy memory leaks

[xnoreq]

mpv version and platform

mpv 0.26.0

Reproduction steps

hwdec=d3d11va-copy
opengl-backend=angle
hwdec-codecs=all

Add a bunch of videos to mpv. Mash the key bound to playlist-next.

Expected behavior

Bounded memory usage. Playing a ~5000 kbps bitrate full hd video I measure about 80 MB private working set.
I don't see a reason why memory usage should increase beyond that, especially when switching to lower bitrate videos.

Actual behavior

Memory usage grows until the system runs out of memory and mpv crashes or is killed.

After roughly 30 times playlist-next:

More detailed process stats also showing leaking handles:
Before:

After roughly 30 skips:

[xnoreq]

Further details:
A detailed look at the handles shows:

• what seems to be graphics driver DirectX cache File & Section & Event handles leaking,
• lots of threads leaking
• the rest are countless unnamed Event & Mutant (mutex, semaphore) type handles leaking

[ghost]

Can't reproduce. Missing log file.

[haasn]

Does setting hwdec=no fix it?

[xnoreq]

@haasn I'm not seeing these leaks with hwdec=no or hwdec-codecs=none.

[haasn]

Sounds like the solution is to stop using hwdec.

[xnoreq]

Or switch to another player that uses the same libav/ffmpeg hardware acceleration but doesn't leak at all.
Thanks and good luck.

[ghost]

Or you could just ignore the troll and post a log file.

[ghost]

Found it - the trick was that you really need multiple files to make it show up, and that the new d3d hwaccel code must be used.

[OneB1t]

i have same issue is there any solution for this problem other than hwacel off?
Even after de6d3f8 it is still broken :-/

Also it looks like leak differs between different GPU architectures (it is leaking much less on my intel 630 based system than on AMD R290X system.)

[CounterPillow]

Open a new issue instead of replying to a closed 3 year old issue.

[OneB1t]

Why when this is probably still relevant?

[avih]

It was reported for D3D11, and at least some leak was fixed at the D3D11 as a result of this report, and for 3 years there were no reports of leaks, so even if it is the same issue (which I think is unlikely), you should open a new issue with proper logs and evidence of the leak.

[OneB1t]

I put it here as i have same symptoms as xnoreq it works fine without hwdec and it is broken with both d3d11va and dxva2
For me it looks like mpv-1.dll is not unloading display driver libraries on dispose when hwdec is used

this is how it steadily eats memory with each new media loaded (im reloading complete mpv.dispose() is called between each play)

when hwdec=off this memory leak is not occuring

here is trace log for this problem but as im using c# mpv wrapper (Mpv.NET) im not sure if log will be useful. There is nothing about dispose of loaded modules
https://0bin.net/paste/YPupCNHd#+6+sl2XZagkFfaYoPeiQ08pQbC2gnvaaluvmx2L+Y96

[avih]

It doesn't look like a leak to me, certainly not anywhere near the OP issue and report. Please open a new issue, with log, and better evidence. It's the last time I'm requesting it, and any further comments you post here will not get any response.

[avih]

Also, if you use mpv.net then report it to mpv.net. If you report it here for mpv then use mpv itself.

[OneB1t]

Does not really matter what wrapper is used as this is not issue of wrapper itself (as with hwdec off it works perfectly fine) wrapper correctly calls "MpvTerminateDestroy TerminateDestroy"

This is how leak looks like on AMD card with video reload every 5 sec (it is much worse than on intel)

[CounterPillow]

OPEN A NEW ISSUE EVERYONE ELSE WHO COMMENTED ON THE ORIGINAL ONE DOESN'T NEED TO RECEIVE NOTIFICATIONS FOR YOUR COMMENTS

[OneB1t]

Maybe that is the reason why i want to reuse this issue ;)

[Akemi]

here we go. comments are locked.