Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv thinks cover is a video track #8561

Closed
jimmy-1000 opened this issue Feb 13, 2021 · 6 comments · Fixed by #14453
Closed

mpv thinks cover is a video track #8561

jimmy-1000 opened this issue Feb 13, 2021 · 6 comments · Fixed by #14453

Comments

@jimmy-1000
Copy link

Actually in not a failure of mpv, but is something that must change.
If I add a cover (for example image jpg) to a video, mpv thinks this embedded picture is a video track and list it that way.
I reported this to SMplayer and the developer told me it was mpv, I checked and it is correct, it is mpv.

If thist is fixed, mpv must show something like this:
Video --vid=1
Audio --aid=2
Cover --cid=3

Or it can be also Picture --pid=3
But by the moment, mpv thinks the picture inside as a cover is a video track, as I said before.

@ChrisK2
Copy link
Member

ChrisK2 commented Feb 13, 2021

Well, it kiiiind of is a video track, just one with one very long frame. How exactly is this a problem? If you just don't want it to be displayed you can disable it with --audio-display=no.

@twilson90
Copy link
Contributor

twilson90 commented Feb 13, 2021

if you check the mpv property "track-list" you'll see the cover art video track is marked with albumart=true, so you can distinguish between 'proper' video tracks and cover art. Makes sense, so I think this should remain the default behaviour.

@Akemi
Copy link
Member

Akemi commented Feb 13, 2021

please leave your unrelated ranting out of the issue comments. i doubt we explicitly ignore your issues out of the +600.

@jimmy-1000
Copy link
Author

jimmy-1000 commented Feb 13, 2021

All of you think the actual behavior is correct?? other players like MPC or VLC don't think the cover is a video track.
And don't forget mpv is the core of many programs.

mpv
1
SMplayer
2
VLC
3
MPC
4

@Akemi
Copy link
Member

Akemi commented Feb 13, 2021

i think that is perfectly fine. it's a video for mpv and it can also be distinguished via the property. players using libmpv as its core should just check for albumart flag to distinguish between normal video tracks and covers.

@7nik
Copy link

7nik commented Jul 30, 2023

for me, mpv not just lists the cover in video tracks but plays the cover image as the default video track facepalm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants