The big pull request of pending changes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a make task and python script to create a Mac OS X Application Bundle to be used when compiling with the --enable-macosx-finder and --enable-macosx-bundle configure flags. Use with `make osxbundle` after running configure and make.
Video Decode Acceleration Framework is a framework by Apple to provide GPU assisted H.264 decoding. It is available on Mac OS X v10.6.3 and later with Mac models equipped with the NVIDIA GeForce 9400M, GeForce 320M, GeForce GT 330M, ATI HD Radeon GFX, Intel HD Graphics and others. This commit uses the new video decoder added in FFmpeg based upon this framework.
Save the cocoa state in an instance variable for the Objective-C part of the code and use a field in the vo struct for the raw C part of the code.
This allows to remove the call to the deprecated `UpdateSystemActivity`. The additional benefit is power management is disabled only if the video is really playing. A paused video will not stop the system from idling.
TickCount is depracted in OS X 10.8. Substitute it with a public Cocoa API call available since OS X 10.6.
QuartzCore was probably forgot after extracting the code from `vo_corevideo`. The OpenGL.h include can be avoided with no warnings/errors.
Use 80columns almost exclusively and reformat Objective-C messages declarations to follow Apple's style (i.e.: - (int)name; instead of - (int) name;).
This commit hopefully makes it easier to follow the flow of the program.
This greatly simplifies the code and makes alt tab behave like it is supposed to: it doesn't put the mplayer window behind the other ones when losing focus. If you have other programs that are displaying themselves above the normal window level, avoid them or use --ontop.
Closed
ghost
mentioned this pull request
jon-y
added a commit
to jon-y/mpv
that referenced
this pull request
Oct 25, 2014
Go through with interface reset and setup if AUDCLNT_E_DEVICE_INVALIDATED is encountered. Fix attempt mpv-player#1. Signed-off-by: Jonathan Yong <10walls@gmail.com>
ghost
mentioned this pull request
12 tasks
6 tasks
6 tasks
6 tasks
6 tasks
6 tasks
Open
6 tasks
6 tasks
6 tasks
6 tasks
6 tasks
6 tasks
6 tasks
6 tasks
na-na-hi
added a commit
to na-na-hi/mpv
that referenced
this pull request
Aug 18, 2024
There are too many issues created with problematic contents (like "mpv-player#1" in uname output) that cause unwanted expansion to markdown formats and links to issues. The information here should be fairly simple in format that markdown isn't needed. Use plain text rendering instead.
na-na-hi
added a commit
to na-na-hi/mpv
that referenced
this pull request
Aug 18, 2024
There are too many issues created with problematic contents (like "mpv-player#1" in uname output) that cause unwanted expansion to markdown formats and links to issues. The information here should be fairly simple in format that markdown isn't needed. Use plain text rendering instead.
sfan5
pushed a commit
that referenced
this pull request
Aug 19, 2024
There are too many issues created with problematic contents (like "#1" in uname output) that cause unwanted expansion to markdown formats and links to issues. The information here should be fairly simple in format that markdown isn't needed. Use plain text rendering instead.
na-na-hi
added a commit
to na-na-hi/mpv
that referenced
this pull request
Sep 28, 2024
There are too many issues created with problematic contents (like "mpv-player#1" in uname output) that cause unwanted expansion to markdown formats and links to issues. The information here should be fairly simple in format that markdown isn't needed. Use plain text rendering instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So these are all the changes that I accumulated over time in my mplayer2
devbranch. I have been using some of this stuff for months now so it should be pretty stable 😄Some things we probably want to implement higher level? (i.e.: power management in the VO is questionable but still better than nothing, it can also be changed later).
Is the syntax for the reformat commit ok? I like adding a
\nafter the assign's=, but does it blend with the current new code in other parts ofmpv?I opened this as a chance to get feedback, if and when I get the positive feedback I can take care of pushing to master.