Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video: Added key conversion from other layouts to english one #12552

Closed
wants to merge 3 commits into from

Conversation

dimok8a
Copy link

@dimok8a dimok8a commented Oct 3, 2023

Fixed the bug, described in issue #45.
Bug: if you have a non-english layout (like Armenian, Arabic or etc.), your key bindings don't work.
I tested this using 3 layouts (Armenian, Arabic and Russian), and it works well. However, it works only with keys related to English alphabet (lower and upper cases).

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Download the artifacts for this pull request:

Windows

@dimok8a dimok8a changed the title Added key conversion from other layouts to english one video: Added key conversion from other layouts to english one Oct 4, 2023
@dyphire dyphire mentioned this pull request Dec 16, 2023
@kasper93
Copy link
Contributor

kasper93 commented Apr 18, 2024

This needs to be rebased and prefix should be win32: ...

I have no idea if this is correct solution to the problem. @na-na-hi maybe you know?

@na-na-hi
Copy link
Contributor

na-na-hi commented Apr 18, 2024

This approach is improper and should be closed. It only deals with English letters, which is insufficient.

I have considered this problem before and I think the right way to do this is to use scancode for layout-independent keyboard handlings. I think this could be done by adding a new suite of keys SCANCODE_XXX.

Also this PR doesn't provide an option to disable this behavior. mpv (and mplayer) has always been dependent on keyboard layout by default.

@kasper93 kasper93 closed this Apr 18, 2024
@kasper93
Copy link
Contributor

I agree this looked to me not complete and that's why I ask. @dimok8a closed for now, feel free to reopen if you came up with better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants