osd_libass: update the OSD bar's dent and border size #12994
Conversation
|
Download the artifacts for this pull request: |
sub/osd_libass.c
Outdated
| @@ -466,7 +466,7 @@ static void update_progbar(struct osd_state *osd, struct osd_object *obj) | |||
| // chapter marks | |||
| for (int n = 0; n < obj->progbar_state.num_stops; n++) { | |||
| float s = obj->progbar_state.stops[n] * width; | |||
| float dent = border * 1.3; | |||
| float dent = border * 4; | |||
There was a problem hiding this comment.
If I set --osd-bar-border-size to the old default of 1, the chapter markers are now too large, and there is no way to control that separately from this option.
Instead of increasing the multiplier, why not set a minimum value instead?
guidocella
force-pushed
the
osd-bar-marker-size
branch
from
5a45b01 to
3872e74
Compare
|
The previous PR suggested a 0.5 thickness but this one suggests 0.4. It seems that a border size of 0.4 instead of 0.5 results in very different visual appearances, shown below. At 1920x1080 output size, 0.4 border size results in uneven top and bottom horizontal line and it appears visually to be more than 20% thinner than 0.5 because the difference of the portion of saturated pixels is larger. At smaller output size of 1280x720, the side borders no longer have saturated white pixels at 0.4 thickness which is not the case for 0.5. I would suggest keep 0.5 as the default unless it's not considered thin enough. 
|
Make the OSD bar markers bigger so we can default to a smaller, better-looking border size, without sacrificing markers' visibility.
guidocella
force-pushed
the
osd-bar-marker-size
branch
from
3872e74 to
cfd2bd6
Compare
|
The unevennes at 0.4+1080p is hard to notice but it's more noticeable at 720p. I made it 0.5 again. I think another good option is 0.3 which seems to be even at both 720p and 1080p, whichever is preferred. |
Make the OSD bar markers bigger so we can default to a smaller, better-looking border size, without sacrificing markers' visibility.