gl_hwdec_vdpau: specify source rect for mixer #1863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDPAU adds padding for some non-standard resolution videos. This padding should be cropped out by giving proper source rect so the input image fit to output surface. This is already done in vo_vdpau so vo_vdpau does not have problem.
ghost
pushed a commit
that referenced
this pull request
Apr 26, 2015
vo_opengl (or gl_hwdec_vdpau.c to be specific) calls mp_vdpau_mixer_render() with video_rect=NULL, which means to use the full surface. This is incorrect if the surface is actually cropped, as it can happen with h264. In this case, it was rendering the parts outside of the image. Fix it by making this case use the cropped size instead. Alternative fix for PR #1863.
|
Your fix was correct. But I made an alternative fix, which is slightly smaller. The problem here is that h264 distinguishes between the "real" frame size (which is used for internal codec operation, and which AFAIK is aligned to macroblocks), and the cropped frame size. FFmpeg and mpv have no real concept of cropping. It's worked around by generally making the output frame size the size of the cropped frame. A cleaner solution would probably explicitly introduce cropping to FFmpeg and mpv. |
ghost
closed this
|
Thanks for fix. |
ghost
pushed a commit
that referenced
this pull request
Apr 27, 2015
vo_opengl (or gl_hwdec_vdpau.c to be specific) calls mp_vdpau_mixer_render() with video_rect=NULL, which means to use the full surface. This is incorrect if the surface is actually cropped, as it can happen with h264. In this case, it was rendering the parts outside of the image. Fix it by making this case use the cropped size instead. Alternative fix for PR #1863. (cherry picked from commit a5ed6e4)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VDPAU adds padding for some non-standard resolution videos.
This padding should be cropped out by giving proper source rect so the input image
fit to output surface.
This is already done in vo_vdpau so vo_vdpau does not have problem.
NOTE: I don't have any reference for this. This is based on what I observed.
I've got a report that some kind of white lines are added at bottom for vdpau with 1280x718 res.
This line is not visible when there's no margin to display this lines, so the screenshot is taken in full screen mode.
Here's the sample file which I used to take the screenshot.
https://drive.google.com/file/d/0B7k0IbH_XHW4RExIbTJpUldOSWM/view?usp=sharing