Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoa: fix fullscreen regression on 10.11 and newer #3577

Closed
wants to merge 1 commit into from

Conversation

Akemi
Copy link
Member

@Akemi Akemi commented Sep 24, 2016

after some tests this fixes #3364 and potentially fixes #2392 (on 10.12) or majorly improves the situation (10.11+).

a bundle can be found here for testing.

@pigoz
Copy link
Member

pigoz commented Sep 24, 2016

Does this not cause any tearing? Why does it work better?

Generally using double buffering is a good idea, and the other backends do use it.

@ghost
Copy link

ghost commented Sep 24, 2016

I suspect the difference doesn't really matter, because OSX is full composited. On the other hand, it must be doing something (just that it has a negative effect here).

From the experiments I had the impression that fullscreen does something similar to "unredirecting" a window on x11 compositors, i.e. giving it direct access to the driver's framebuffer. Maybe disabling double buffering makes the window always composited? (I'm just guessing here.)

@ghost
Copy link

ghost commented Sep 26, 2016

Merged.

@ghost ghost closed this Sep 26, 2016
@Akemi Akemi deleted the fullscreen_bug branch September 26, 2016 18:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG/Request] OS X OpenGL compatibility issue Fullscreen performance regression on OS X El Capitan
2 participants