Feature e2e #55
Merged
Feature e2e #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pagnkelly
commented
Nov 25, 2022
pagnkelly
commented
- 增加e2e测试插件
- 增加ts模块有测试模块时，tsconfig增加jest的类型校验
CommanderXL
reviewed
Nov 25, 2022
| }) | ||
|
|
||
| api.extendPackage({ | ||
| devDependencies: { |
There was a problem hiding this comment.
这部分的依赖看起来应该是 vue-cli-plugin-mpx-e2e-test 这个插件自身的依赖，所以感觉放到这个插件自身的 package.json 的 dependencies 里面去收敛管理这些依赖比较合理一些。
因为通过 api.extendPackage 是改的业务项目的 package.json，那么会遇到的场景就是这个插件相关的依赖升级，那么业务项目只需要升级 vue-cli-plugin-mpx-e2e-test 这个插件的版本即可，然后对应的依赖也得到更新。这样业务项目就不再需要单独关心到底升级具体哪个插件的版本。
There was a problem hiding this comment.
看起来其他有几个插件也是通过 api.extendPackge 去管理依赖，我们这边也按这个策略优化一下。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.