fix: web inspect #66
Merged
fix: web inspect #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderXL
reviewed
Jun 14, 2023
| @@ -108,7 +108,6 @@ module.exports.handleWebpackDone = function (err, stats, target) { | |||
| : 'successfully' | |||
| const result = [] | |||
| if (hasErrors) result.push(extractResultFromStats(stats)) | |||
| if (hasWarnings) result.push(extractErrorsFromStats(stats, 'warnings')) | |||
| if (!hasErrors) result.push(extractResultFromStats(stats)) | |||
There was a problem hiding this comment.
- 这个逻辑有点奇怪，hasErrors 不管是否为真，都执行了 result.push(...) 这个逻辑；
- hasWarning 这个逻辑去掉的原因是什么？
CommanderXL
reviewed
Jun 14, 2023
| if (target.env) process.env.NODE_ENV = target.env | ||
| const res = resolveWebBuildWebpackConfig(api, options, args) | ||
| const output = toString(res, { verbose }) | ||
| console.log(highlight(output, { language: 'js' })) |
There was a problem hiding this comment.
这部分的逻辑看起来和上面的 inpsect:mp 是一样的，可以抽出来？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.