Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileContainer: add path and meta properties #121

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Oct 18, 2024

Once again I am not sure about the names. Should it be paths and meta or path and meta, or paths and metas? Or ...?

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (ddeadd1) to head (53bb3ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   99.66%   99.67%           
=======================================
  Files           5        5           
  Lines         303      310    +7     
=======================================
+ Hits          302      309    +7     
  Misses          1        1           
Flag Coverage Δ
unittests 99.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause changed the title FileContainer: add path and meta properies FileContainer: add path and meta properties Nov 4, 2024
@mathause
Copy link
Collaborator Author

mathause commented Nov 4, 2024

@veni-vidi-vici-dormivi once again I call on your naming expertise 😉

@veni-vidi-vici-dormivi
Copy link
Collaborator

My intuition is paths and meta.

@mathause
Copy link
Collaborator Author

mathause commented Nov 4, 2024

thanks 🤗

@mathause mathause merged commit 78c20cc into main Nov 4, 2024
7 checks passed
@mathause mathause deleted the fc_meta_path_property branch November 4, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants