Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs #134

Merged
merged 12 commits into from
Jan 6, 2025
Merged

Add docs #134

merged 12 commits into from
Jan 6, 2025

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi commented Jan 3, 2025

Added sphinx documentation to the package.
Closes #86

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 99.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
filefisher/_filefinder.py 100.00% <ø> (ø)

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

@mathause can you add the project to readthedocs and enable PR builds please?

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Should I also add something about the installation?

Also, we could rethink the README now.

@mathause
Copy link
Collaborator

mathause commented Jan 3, 2025

@mathause can you add the project to readthedocs and enable PR builds please?

Done. You'll need to add a docs extra to the setup.cfg. (and probably other stuff 😉)

Should I also add something about the installation?

Also, we could rethink the README now.

Yes should definitively do this. Add usage. Maybe in another PR.

@mathause
Copy link
Collaborator

mathause commented Jan 3, 2025

Close / reopen

@mathause mathause closed this Jan 3, 2025
@mathause mathause reopened this Jan 3, 2025
@mathause
Copy link
Collaborator

mathause commented Jan 4, 2025

Oh yes and I always forget how to enable 3rd party apps: readthedocs/readthedocs.org#5851 (comment)

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Looking good.

Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great!

Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@mathause mathause merged commit 9672ca9 into mpytools:main Jan 6, 2025
7 checks passed
@mathause
Copy link
Collaborator

mathause commented Jan 6, 2025

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add docs?
2 participants