Skip to content

fix(e2e): support all platforms in setupIsolatedSocketPath #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpyw merged 1 commit into from
Jan 19, 2026
Merged

fix(e2e): support all platforms in setupIsolatedSocketPath #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ jobs:
runs-on: windows-latest
if: >-
github.ref == 'refs/heads/main' ||
github.ref == 'refs/heads/multicloud' ||
contains(github.event.head_commit.message, '[CI: windows]')
defaults:
run:
Expand Down
10 changes: 7 additions & 3 deletions e2e/staging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,12 +1231,16 @@ func TestDaemonLauncher_ViaStore(t *testing.T) {
})
}

// setupIsolatedSocketPath sets TMPDIR to a temp directory, causing the daemon
// to look for a socket in a different location where no daemon is running.
// setupIsolatedSocketPath sets socket-related environment variables to a temp directory,
// causing the daemon to look for a socket in a different location where no daemon is running.
// This simulates the "daemon not running" scenario for E2E tests.
// Darwin uses TMPDIR, Linux uses XDG_RUNTIME_DIR, Windows uses LOCALAPPDATA.
func setupIsolatedSocketPath(t *testing.T) {
t.Helper()
t.Setenv("TMPDIR", t.TempDir())
tempDir := t.TempDir()
t.Setenv("TMPDIR", tempDir)
t.Setenv("XDG_RUNTIME_DIR", tempDir)
t.Setenv("LOCALAPPDATA", tempDir)
}

// TestDaemonLauncher_NotRunning tests launcher behavior when daemon is not running.
Expand Down