feat(staging): split state.json into param.json and secret.json#144
Merged
mpyw merged 1 commit intomulticloudfrom Jan 19, 2026
Merged
feat(staging): split state.json into param.json and secret.json#144mpyw merged 1 commit intomulticloudfrom
mpyw merged 1 commit intomulticloudfrom
Conversation
4ef6dfd to
1d0cb83
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## multicloud #144 +/- ##
==============================================
+ Coverage 90.08% 90.14% +0.06%
==============================================
Files 133 133
Lines 7754 7807 +53
==============================================
+ Hits 6985 7038 +53
Misses 526 526
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
19ee51f to
9c5d2b1
Compare
Refactor file-based staging store to use separate files for each service: - param.json for Parameter Store entries - secret.json for Secrets Manager entries Changes: - Store now uses stateDir instead of stateFilePath - Add NewStoreWithDir constructor, deprecate NewStoreWithPath - Drain merges state from both service files - WriteState writes to appropriate file(s) based on service filter - Delete removes both files - Exists returns true if either file exists - IsEncrypted checks both files This separation prepares for multi-cloud support where different providers may have different service availability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9c5d2b1 to
3b1b4f2
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
param.jsonfor Parameter Store entriessecret.jsonfor Secrets Manager entriesChanges
Storenow usesstateDirinstead ofstateFilePathNewStoreWithDirconstructor, deprecateNewStoreWithPathDrainmerges state from both service filesWriteStatewrites to appropriate file(s) based on service filterDeleteremoves both filesExistsreturns true if either file existsIsEncryptedchecks both filesWhy
This separation prepares for multi-cloud support where different providers may have different service availability (e.g., GCP only has Secret Manager, no Parameter Store equivalent).
Test plan
🤖 Generated with Claude Code