Skip to content

refactor(model): move AWS-specific fields to metadata structs#151

Merged
mpyw merged 1 commit intomulticloudfrom
refactor/usecase-tag-provider-interfaces
Jan 19, 2026
Merged

refactor(model): move AWS-specific fields to metadata structs#151
mpyw merged 1 commit intomulticloudfrom
refactor/usecase-tag-provider-interfaces

Conversation

@mpyw
Copy link
Owner

@mpyw mpyw commented Jan 19, 2026

Summary

  • Move provider-specific fields from base types to metadata structs for multi-cloud support
  • Parameter.TypeAWSParameterMeta.Type
  • ParameterListItem.TypeAWSParameterListItemMeta.Type (new)
  • Secret.ARNAWSSecretMeta.ARN
  • SecretListItem.ARN, DeletedDateAWSSecretListItemMeta (new)
  • Add AWSMeta() helper methods for type-safe metadata access

Test plan

  • make build passes
  • make test passes
  • make lint passes

🤖 Generated with Claude Code

Move provider-specific fields from base types to metadata:
- Parameter.Type -> AWSParameterMeta.Type
- ParameterListItem.Type -> AWSParameterListItemMeta.Type (new)
- Secret.ARN -> AWSSecretMeta.ARN
- SecretListItem.ARN, DeletedDate -> AWSSecretListItemMeta (new)

Add AWSMeta() helper methods for type-safe metadata access.
Update AWS adapters to populate metadata fields correctly.

This makes base types provider-agnostic for multi-cloud support.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 14.63415% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.87%. Comparing base (53ecc39) to head (61500ff).
⚠️ Report is 1 commits behind head on multicloud.

Files with missing lines Patch % Lines
internal/model/parameter.go 25.00% 9 Missing ⚠️
internal/model/secret.go 25.00% 9 Missing ⚠️
internal/provider/aws/secret/adapter.go 0.00% 9 Missing ⚠️
internal/provider/aws/param/adapter.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           multicloud     #151      +/-   ##
==============================================
- Coverage       87.14%   86.87%   -0.28%     
==============================================
  Files             139      139              
  Lines            8170     8198      +28     
==============================================
+ Hits             7120     7122       +2     
- Misses            806      831      +25     
- Partials          244      245       +1     
Flag Coverage Δ
e2e 64.53% <0.00%> (-0.23%) ⬇️
platform-darwin 64.38% <ø> (ø)
platform-linux 62.85% <ø> (ø)
platform-windows 73.46% <ø> (ø)
unittests 76.19% <14.63%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpyw mpyw merged commit 39c14f8 into multicloud Jan 19, 2026
23 of 25 checks passed
@mpyw mpyw deleted the refactor/usecase-tag-provider-interfaces branch January 19, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant