refactor(model): move AWS-specific fields to metadata structs#151
Merged
mpyw merged 1 commit intomulticloudfrom Jan 19, 2026
Merged
refactor(model): move AWS-specific fields to metadata structs#151mpyw merged 1 commit intomulticloudfrom
mpyw merged 1 commit intomulticloudfrom
Conversation
Move provider-specific fields from base types to metadata: - Parameter.Type -> AWSParameterMeta.Type - ParameterListItem.Type -> AWSParameterListItemMeta.Type (new) - Secret.ARN -> AWSSecretMeta.ARN - SecretListItem.ARN, DeletedDate -> AWSSecretListItemMeta (new) Add AWSMeta() helper methods for type-safe metadata access. Update AWS adapters to populate metadata fields correctly. This makes base types provider-agnostic for multi-cloud support. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## multicloud #151 +/- ##
==============================================
- Coverage 87.14% 86.87% -0.28%
==============================================
Files 139 139
Lines 8170 8198 +28
==============================================
+ Hits 7120 7122 +2
- Misses 806 831 +25
- Partials 244 245 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameter.Type→AWSParameterMeta.TypeParameterListItem.Type→AWSParameterListItemMeta.Type(new)Secret.ARN→AWSSecretMeta.ARNSecretListItem.ARN,DeletedDate→AWSSecretListItemMeta(new)AWSMeta()helper methods for type-safe metadata accessTest plan
make buildpassesmake testpassesmake lintpasses🤖 Generated with Claude Code