refactor(model): unify field names for multi-cloud compatibility#152
Merged
mpyw merged 3 commits intomulticloudfrom Jan 20, 2026
Merged
refactor(model): unify field names for multi-cloud compatibility#152mpyw merged 3 commits intomulticloudfrom
mpyw merged 3 commits intomulticloudfrom
Conversation
- Change ShowClient interface to use provider.ParameterReader and provider.ParameterTagger instead of paramapi types - Move version resolution logic (shift handling) to usecase layer - Update ShowOutput to use string types for Version and Type (provider-agnostic, no longer tied to AWS-specific enums) - Update CLI show command to use awsparam.NewAdapter - Update GUI ParamShow to use awsparam.NewAdapter with parseInt64 helper - Update all tests to use model.Parameter and model.AWSParameterMeta Part of multi-cloud refactoring: PR #2 (Read UseCase Migration) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename Secret.VersionID to Version (consistent with Parameter) - Rename Parameter.LastModified to UpdatedAt - Rename Secret.CreatedDate to CreatedAt - Add UpdatedAt field to Secret for providers that track both dates - Update all layers: model, provider, usecase, cli, gui This makes the model layer truly provider-agnostic, supporting AWS, Azure, and GCP field semantics uniformly. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## multicloud #152 +/- ##
==============================================
+ Coverage 86.87% 87.82% +0.94%
==============================================
Files 139 139
Lines 8198 8204 +6
==============================================
+ Hits 7122 7205 +83
+ Misses 831 753 -78
- Partials 245 246 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ion helper - Move version resolution logic from usecase to paramversion.GetParameterWithVersion() - Update paramversion to use provider.ParameterReader interface - Add ParamReader field to staging diff runner for version resolution - Use hybrid approach in staging: Client for apply ops, Reader for version resolution - Update all test files with correct mocks for new interfaces Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Secret.VersionID→Version(consistent with Parameter)Parameter.LastModified→UpdatedAtSecret.CreatedDate→CreatedAtUpdatedAtfield to Secret for providers that track both datesMotivation
The previous model types were too AWS-centric. This change makes the model layer truly provider-agnostic, supporting AWS, Azure, and GCP field semantics uniformly.
Test plan
go test ./...passesmake lintpasses🤖 Generated with Claude Code