refactor(usecase): migrate write operations to provider interfaces#153
Merged
mpyw merged 1 commit intomulticloudfrom Jan 20, 2026
Merged
Conversation
Migrate all write use cases (create, update, delete, restore) from AWS-specific API interfaces to cloud-agnostic provider interfaces. Changes: - Update provider interfaces with write result types - Migrate param/create, param/update, param/delete use cases - Migrate secret/create, secret/update, secret/delete, secret/restore - Update CLI commands to use AWS adapters - Update GUI to use AWS adapters - Update all related tests with new mock implementations This completes PR #3 of the multi-cloud refactoring roadmap. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## multicloud #153 +/- ##
==============================================
+ Coverage 87.79% 88.32% +0.52%
==============================================
Files 139 139
Lines 8204 8168 -36
==============================================
+ Hits 7203 7214 +11
+ Misses 754 698 -56
- Partials 247 256 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParameterWriteResult,SecretWriteResult,SecretDeleteResult,SecretRestoreResult)This completes PR #3 of the multi-cloud refactoring roadmap.
Changes
Provider Layer
internal/provider/parameter.go- AddParameterWriteResultreturn type toPutParameterinternal/provider/secret.go- Add result return types to write operationsinternal/provider/aws/param/adapter.go- UpdatePutParameterto return resultinternal/provider/aws/secret/adapter.go- Update write methods to return resultsModel Layer
internal/model/parameter.go- AddParameterWriteResulttypeinternal/model/secret.go- AddSecretWriteResult,SecretDeleteResult,SecretRestoreResulttypesUse Case Layer
internal/usecase/param/create.go- Use provider interfaceinternal/usecase/param/update.go- Use provider interface, addGetCurrentValueinternal/usecase/param/delete.go- Use provider interfaceinternal/usecase/secret/create.go- Use provider interfaceinternal/usecase/secret/update.go- Use provider interface (removed Description support)internal/usecase/secret/delete.go- Use provider interface (removed RecoveryWindow from input)internal/usecase/secret/restore.go- Use provider interfaceCLI Layer
awsparam.NewAdapter()/awssecret.NewAdapter()getCurrentValuefrom CLI layer (moved to usecase)update_internal_test.goGUI Layer
internal/gui/param.go- Use adapter for ParamSet, ParamDeleteinternal/gui/secret.go- Use adapter for SecretCreate, SecretUpdate, SecretDelete, SecretRestoreTest plan
make test- All tests passmake lint- No issues🤖 Generated with Claude Code