[ntfy] Fix submitting newline characters in notification message text #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
==========================================
+ Coverage 49.33% 49.51% +0.17%
==========================================
Files 81 81
Lines 3973 3993 +20
==========================================
+ Hits 1960 1977 +17
- Misses 2013 2016 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
amotl
force-pushed
the
amo/fix-ntfy-newlines
branch
from
7c42436
to
731afef
Compare
|
Great job! I was looking forward to this release. Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @codebude and @zoic21,
this patch has been grown in July already, but only now I have been able to wrap it up. It is based on the suggestion by @codebude shared at #677 (comment), thank you very much.
With kind regards,
Andreas.
P.S.: I will be happy about a review, both on code and/or functionality, either before, or after merging and releasing. If it's about code, commenting on this PR will be the appropriate spot. If it is about the outcome, I'd say we just continue our conversation at GH-677, independently of this PR.