Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore path when connect as MQTTS. #700

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Ignore path when connect as MQTTS. #700

merged 2 commits into from
Oct 16, 2017

Conversation

redboltz
Copy link
Contributor

@redboltz redboltz commented Oct 16, 2017 •
edited
Loading

This PR fixes #699.

@redboltz redboltz mentioned this pull request Oct 16, 2017
Closed
@codecov
Copy link

codecov bot commented Oct 16, 2017 •
edited
Loading

Codecov Report

Merging #700 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage    92.7%   92.71%   +0.01%     
==========================================
  Files           8        8              
  Lines         685      686       +1     
  Branches      167      167              
==========================================
+ Hits          635      636       +1     
  Misses         50       50
Impacted Files Coverage Δ
lib/connect/tls.js 94.73% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe4d75...6384341. Read the comment docs.

@mcollina
Copy link
Member

can you please add a unit test for this?

@mcollina mcollina mentioned this pull request Oct 16, 2017
Closed
3 tasks
@redboltz
Add unit tests.
6384341 
'should validate successfully the CA using URI with path' fails if this
PR is not applied.
@redboltz
Copy link
Contributor Author

Hi @mcollina,
Sure. I just added unit tests for the PR.

@mcollina mcollina merged commit db7b0d4 into mqttjs:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MQTTS connection error on nodejs >= 8.6.0
2 participants
@redboltz @mcollina