enhance debug output, fix docbook behavior, allow separate input for POT #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is without addendum Signed-off-by: Osamu Aoki <osamu@debian.org>
Split lines to separate array items to ensure expected search operation for addendum. Use /(?<=\n)/ trick to avoid adding extra line breaks Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
POT/PO file updated by the secondary master file specified in pot_in if it is specified. Otherwise the same master file used for creating the output file. Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Perl's one dimensional array creates big barrier for non-perl users to read code. Signed-off-by: Osamu Aoki <osamu@debian.org>
tags in untranslated tag list don't take W nor w translation option since these are only valid for translated tags Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Debug code enabled by --debug Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Two style:
One by how to set via -o option
Another by how internal logic use as controlling flags
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Adjust test case Signed-off-by: Osamu Aoki <osamu@debian.org>
mquinson
reviewed
Oct 15, 2018
lib/Locale/Po4a/Xml.pm
Outdated
|
|
||
| =head2 DEFINE WHAT TAGS AND ATTRIBUTES TO TRANSLATE | ||
|
|
||
| The simplest customization is to define which tags and attributes you want | ||
| The simplest customization is to define whicattributes you want |
|
Hello, many many thanks for these changes, I just read the whole patch, and this is a very impressive piece of code. The added comments and debug messages are a real asset for the future of the project. Unfortunately, some tests seem to fail on travis. Could you please fix it? I think that one of the problems is that a full path gets displayed, making the test unreproducible. Also, you did not add anything to the NEWS file. Could you please document your contribution here? Thanks again, |
This should fix failure on travis. Signed-off-by: Osamu Aoki <osamu@debian.org>
I must have accidentally typed some vim key while updating something else. Signed-off-by: Osamu Aoki <osamu@debian.org>
This gets ready for Perl 5.32. (Debian's #903735) Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
Signed-off-by: Osamu Aoki <osamu@debian.org>
|
Wonderful, thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #148 was auto closed, I am creating new merge request.
This has much cleaner history... I hope you can accept this one.