asciidoc: process transparent index entries in their own segment #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses the issue of keeping transparent index entries in paragraphs. It does not address "visible" index entries, which are formatted with ((...)). This addresses GH mquinson#416.
|
Well, this was a bit too fast a merge. I should have marked this as a draft, because some checks were expected from @suddenfall |
|
woops, sorry. |
|
I reviewed your changes, and it seemed very reasonable. I just added a comment after merging your work. If @suddenfall finds further difficulties, we can always do an additional PR. Next time, I'll be more cautious when you ask for reviews in the comments... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the issue of keeping transparent index entries in paragraphs. It does not address "visible" index entries, which are formatted with ((...)).
This addresses GH #416.