lib: Texinfo: Translate partial menu node names. #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <https://issues.guix.gnu.org/64881>. * lib/Locale/Po4a/Texinfo.pm (translate_buffer_menuentry): Refine regexp, so that it matches menu entries lacking a description. Only call 'translate_buffer' on the description if it was provided. * t/fmt/texinfo/partialmenus.trans: New file. * t/fmt/texinfo/partialmenus.texi: Likewise. * t/fmt/texinfo/partialmenus.pot: Likewise. * t/fmt/texinfo/partialmenus.po: Likewise. * t/fmt/texinfo/partialmenus.norm: Likewise. * t/fmt-texinfo.t: Register the new 'partialmenus' test.
trofi
added a commit
to trofi/nix-guix-gentoo
that referenced
this pull request
Sep 9, 2023
Without the mquinson/po4a#437 change guix build fails to build translated manpages.
|
Thanks a lot, merged! Your help is particularly precious because I'm far from being able to update/fix the Texinfo module... Just a small comment: please also update the NEWS file to document your change, and my pleasure will be perfect. Thanks again, |
|
Noted for future contributions, thanks for the review/merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.guix.gnu.org/64881.