man: fix po4a's incorrect handling of \& in doblequotes #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely do `s/\\&"/\\(dq/` only until after we handle all the quotes that might separate commands' arguments. Closes: mquinson#445 Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
mquinson
reviewed
Nov 12, 2024
| } else { | ||
| die wrap_ref_mod( $ref, "po4a::man", dgettext( "po4a", "Cannot parse command arguments: %s" ), $arguments ); | ||
| } | ||
| $a =~ s/\\&"/\\(dq/g if (defined $a); | ||
| push @args, $a; |
There was a problem hiding this comment.
Just reading the code, it seems to me that we could push undef to @args if $a is not defined. If that's impossible, then the test at the end of line 1694 is probably useless.
There was a problem hiding this comment.
I've assumed it could be undef since there are analogous checks on lines 1682 and 1688. But now I don't see how it actually could. I suppose we can drop all those checks all together, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely do
s/\\&"/\\(dq/only until after we handle all the quotes that might separate commands' arguments.Closes: #445