-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Paid reaction #156
base: main
Are you sure you want to change the base?
Add Paid reaction #156
Conversation
Reviewer's Guide by SourceryThis pull request adds support for a new "Paid" reaction type to the existing reaction system. The changes involve modifying the ReactionType struct and updating the JSON marshaling and unmarshaling methods to handle the new reaction type. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Froctnow - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a
fmt.Println(reaction)
in the default case of the UnmarshalJSON function. This looks like debugging code and should be removed before merging. - The ReactionTypePaid struct only contains a Type field. Consider if there are any other attributes specific to paid reactions that should be included, similar to how CustomEmojiID is included for custom emoji reactions.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@mr-linch Hi, telegram has released update with a new reaction type. I've added new reaction type in your code, but there is a problem, the package with proto (or something else source) is private, I mean go-tg-gen, and I've made changes in code, but you have to change proto and update PR, or create new with correct changes |
Summary by Sourcery
Add a new 'Paid' reaction type to the reaction system, enabling the handling and serialization of paid reactions alongside existing emoji and custom emoji types.
New Features: