Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previouse change related to Louisvdw#950 for JK bms can broke older "Black" JK bms devices. See fix in
jkbms_can.py
.JK BMS cells are updating very slowly via can bus and cell count can be increased few times before all detected. This causes exception in
dbushelpre.py
at lineself._dbusservice[cellpath % (str(i + 1))] = voltage
. In the end the cell voltage values were missing and not updated in VenusOS. So I added option to preset cell count for JK CANJKBMS_CAN_CELL_COUNT
which resolves the issue. Original logic is kept so the parameter is optional and not necessary if it works without.Last change in this PR fixes the reinstall shell script. It may happen that user has can2, but not can0 used by dbus-serialbattery. The original detection for can0 didn't work in such case. I included same fix for BLE even it may not be necessary.