Delete all stubs #89
Delete all stubs #89
Conversation
src/portals/admin.js
Outdated
| this.endpoints.delete(id, callback); | ||
| if (id) { | ||
| this.endpoints.delete(id, callback); | ||
| } else { |
There was a problem hiding this comment.
The only change I would ask is to ensure that the request was to / to delete everything, instead of deleting everything if an id wasn't captured.
There was a problem hiding this comment.
No worries 👍
Out of curiosity; what is an example url that might be something without an id? Is it just anything that isn't a number eg. /test? Or with multiple directories in the path? eg. /123/test. I just want to make sure I cover the right scenarios in a test.
There was a problem hiding this comment.
Those are good examples. I think the code as-is may actually work correctly (due to multiple checks against urlPattern) but for a "delete everything" capability it is good to have tests ensuring it works as intended only on / in case other capabilities are added later.
There was a problem hiding this comment.
Sounds good. I'll sort that out today.
I've added a DELETE method on the root admin url eg.
This will delete all stubs. It's quite handy for something like functional testing where you are setting up / tearing down fixture data for each test. The alternative is having to maintain a list of IDs for every stub you create.