Remove custom newSeqUninit if available in stdlib
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these cases we are only dealing with mem copyable POD types, so it's fine to use the stdlib version.
The proc is deprecated anyway and the minor performance penalty should be irrelevant.
|
Hi, it doesn't seem to handle all the cases.
|
|
Oh, I didn't realize these would be non mem copyable. I'll investigate and fix it! edit: Ah, right, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes over from #591. We now use the stdlib
newSeqUninitif available, i.e. after nim-lang/Nim#22739.