Warning and Hint removal #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were actually made by Vindaar <batsi90@gmail.com>. I only completed the SVG test.
…ix (pinv) and the conjugate of a complex tensor
Code to fix the issue was provided by @Vindaar.
There are still a few left which I did not "fix" because IMHO they make the code clearer by naming all outputs of procedures that return tuples.
While this change fixes the warning (by renaming one of the two templates, which works because they term rewriting macros should never be called explicitly), I am not sure that this code is ever triggered (with or without my fix).
…las to the README.
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few warnings and hints. There are still a few left. Those are mostly related to =destroy and some unused variables which I think make the code clearer so I prefer not to fix them for now.