Missing numpy functions #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelEzquerra
force-pushed
the
missing_numpy
branch
from
4c2f912
to
4b5f1d9
Compare
AngelEzquerra
force-pushed
the
missing_numpy
branch
from
b35f402
to
7e242c1
Compare
|
I rebased this branch on top of the latest master branch. |
AngelEzquerra
force-pushed
the
missing_numpy
branch
3 times, most recently
from
89ca2cc
to
e76e885
Compare
|
Added missing |
|
Also great work on this! 🥳 After merging the other two (and having dropped 1.4 support), CI should pass for this one too. Can never remember whether you'll need to rebase onto the then-master without 1.4 though. |
AngelEzquerra
force-pushed
the
missing_numpy
branch
from
e76e885
to
a21ec7c
Compare
Also tweaks the assert messages of the diagonal() proc a little to match similar messages in the new functions.
Tests have been added to test_diag.nim which will be renamed to test_special_matrices.nim.
Also adds messages to a couple of asserts on the linspace procedure.
Also adds a corresponding test.
…ar` module in all docstrings.
`flatten` flattens a tensor, returning a rank-1 tensor with the same data as the input. This is the same as `t.reshape([t.size.int])`. Therefore, if possible no data copy is done and the returned tensor shares data with the input. If input is not contiguous, this is not possible and a copy will be made.
Support for higher rank tensors will be added later.
This adds two roll types (which are the same for rank 1 tensors, but different for higher rank tensors): "global" (axis-less) roll and "axis" roll. The former flattens the input tensor before rolling the elements and then reshapes the rolled tensor back to the original shape, while the latter rolls the positions of _slices_ of a tensor taken along a specific axis.
AngelEzquerra
force-pushed
the
missing_numpy
branch
from
a21ec7c
to
fbe2ce8
Compare
|
Thanks again! Great work. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of missing numpy functions:
I'd like to add more but I think this is a good first set.